wth - (SPARCDashboard, SPARCRequest & Data) Admin Rate Label Change a… #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayla-glick
suggested changes
Jul 27, 2018
| @@ -41,7 +41,9 @@ def sla_service_rate_display line_item | |||
| end | |||
|
|
|||
| def sla_your_cost_field line_item | |||
| raw( text_field(:line_item, :service, class: 'your-cost-edit', value: number_with_precision(Service.cents_to_dollars(line_item.applicable_rate), precision: 2)) ) | |||
| link_to 'javascript:void(0);', class: [("your-cost editable"), ('text-danger' if line_item.admin_rates.present?)], data: { url: dashboard_line_item_path(line_item), title: line_item.admin_rates.present? ? 'Modified Rate' : 'Admin Rate' }do | |||
There was a problem hiding this comment.
Can you add this text to en.yml?
| $(document).on 'load-success.bs.table', '.study_level_activities', -> | ||
| setup_xeditable_fields() | ||
|
|
||
| $('body').tooltip( |
There was a problem hiding this comment.
This is a good idea. At some point we should streamline our tooltips to do this using a global JS function.
There was a problem hiding this comment.
Yeah. The only reason I came across this was because tooltips and x-editable fields don't play nicely. Reason being the data: { toggle: 'tooltip' } part
kayla-glick
approved these changes
Jul 27, 2018
…nd Visual Cue Background: Currently, the admin rate is an attribute on Line Item level. When an admin user set an admin rate on a service in a request, and then add the same service in SPARCFulfillment (which was not pushed from SPARCRequest), SPARCFulfillment considers it as a service with the normal rate rather than admin rate. Please: 1). Make the format of the "Non-clinical Service" "Your Cost" editable field consistent with the other ones in SPARCDashboard Admin Edit Section “Clinical Services” Tab (see 2nd screenshot attached); 2). Add a visual cue (such as "(Modified)" sign or "M" icon with "Modified Rate" tooltip next to the cost in green color) for admin rate (SPARCRequest & SPARCDashboard). The corresponding SPARCFulfillment story can be found here: https://www.pivotaltracker.com/story/show/156286625 [#156275541] Story - https://www.pivotaltracker.com/story/show/156275541 fixed specs and yml fix specs fix specs
Stuart-Johnson
approved these changes
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd Visual Cue
Background: Currently, the admin rate is an attribute on Line Item level. When an admin user set an admin rate on a service in a request, and then add the same service in SPARCFulfillment (which was not pushed from SPARCRequest), SPARCFulfillment considers it as a service with the normal rate rather than admin rate.
Please:
1). Make the format of the "Non-clinical Service" "Your Cost" editable field consistent with the other ones in SPARCDashboard Admin Edit Section “Clinical Services” Tab (see 2nd screenshot attached);
2). Add a visual cue (such as "(Modified)" sign or "M" icon with "Modified Rate" tooltip next to the cost in green color) for admin rate (SPARCRequest & SPARCDashboard).
The corresponding SPARCFulfillment story can be found here: https://www.pivotaltracker.com/story/show/156286625
[#156275541]
Story - https://www.pivotaltracker.com/story/show/156275541