Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KG - Original Submitted Date Backfill Edge Case #1843

Merged
merged 1 commit into from May 8, 2019
Merged

KG - Original Submitted Date Backfill Edge Case #1843

merged 1 commit into from May 8, 2019

Conversation

kayla-glick
Copy link
Contributor

https://www.pivotaltracker.com/story/show/162964012

However, I did notice that there are still 62 leftover Service Requests on -d after the script was run, that had 'submitted' status and 'submitted_at' date, but null "original_submitted_date". When I looked into the related protocols, I found out that the protocols were all empty. That's the edge case when users went back to a previously submitted protocol and deleted all requests.

In this case (and only in this case), we should probably just use the SR 'submitted_at' date to fill in the SR 'original_submitted_date', because that's our best bet. Please look into that.

@Stuart-Johnson Stuart-Johnson merged commit 94c663b into v3.5.0 May 8, 2019
@Stuart-Johnson Stuart-Johnson deleted the kg-inital_submitted_at_script branch May 8, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stuart-Johnson Stuart-Johnson Stuart-Johnson approved these changes

@marklohr marklohr marklohr approved these changes

Assignees
No one assigned
Labels
enhancement MUSC version 3.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kayla-glick @Stuart-Johnson @marklohr