Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAW - Bootstrap 4 Reports Fixes #2034

Merged
merged 4 commits into from Oct 8, 2019
Merged

SAW - Bootstrap 4 Reports Fixes #2034

merged 4 commits into from Oct 8, 2019

Conversation

SamWord
Copy link
Contributor

@SamWord SamWord commented Oct 4, 2019

Fixes to the SPARCReports after updating it to use Bootstrap 4: #166643689

Fixes include:

  • Adding line break between SPARCReports header text and subtitle text
  • Fixing reports that wouldn't generate due to a time parsing error with the new bootstrap selectpicker
  • (Not part of the comments on this story) I noticed the errors weren't working when required fields were left blank on a report form. I updated the error text to work and match the error text in other areas of SPARC.

@Stuart-Johnson Stuart-Johnson merged commit 097c914 into v3.6.0 Oct 8, 2019
@Stuart-Johnson Stuart-Johnson deleted the bs4-reports branch October 8, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stuart-Johnson Stuart-Johnson Stuart-Johnson approved these changes

@kayla-glick kayla-glick kayla-glick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SamWord @Stuart-Johnson @kayla-glick