Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAW - Bootstrap 4 Forms Styling Fixes #2042

Merged
merged 6 commits into from Oct 18, 2019
Merged

Conversation

SamWord
Copy link
Contributor

@SamWord SamWord commented Oct 15, 2019

Changed the styling according to comments on #166643537

  • Table sizing is now auto since col sizing doesn't work on tables in Chrome. Auto sizing also looks nicer in general.
  • Buttons stay in a horizontal line in Chrome.
  • Added word break to saved response filters in case a user makes a response filter with a really long name.
  • The export button on the responses table was broken so I fixed it to properly export .xlsx files.
  • While I was fixing the export bug, I found that one of the surveys had a "/" in the name, causing another bug where an excel sheet name was invalid. Regex used to match characters based off of this: https://stackoverflow.com/questions/451452/valid-characters-for-excel-sheet-names

@Stuart-Johnson Stuart-Johnson merged commit ed2119d into v3.6.0 Oct 18, 2019
@Stuart-Johnson Stuart-Johnson deleted the bs4-forms-fixes branch October 18, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants