SAW - Plain text document upload bug #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#170650880
There was no issue with uploading actual plain text files. This was an issue of just changing the extension of a rich text file from .rtf to .txt. Since renaming the extension does not actually convert the file format, Paperclip was (correctly) determining that the file was spoofed. Paperclip assigned a vague "Invalid file type" message to files that were spoofed. A custom error message was added to make it clear that the file type does not match the file's contents.
Additionally, from my own testing, Paperclip seems to have a bug that determines all rich text files are spoofed, preventing the user from uploading rich text files. This should be fixed when we upgrade to using ActiveStorage #169848801. For now, .rtf files were removed from the list of supported files.