KG - RMID Validated Flag When RMID Removed #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/169095503
Background
When a Research Master ID (RMID) is removed from a SPARC protocol, and that protocol already had a "rmid_validated" flag on it, currently it is keeping that validation flag, although RMID is not associated with the SPARC record any more. (i.e., currently on -d when I query amount protocols.rmid = NULL and protocols.rmid_valdiated = 1, protocols 13781 and 12343 shows up).
Acceptance Criteria
1). When a RMID number is removed from SPARC protocol on SPARCRequest Step 2 or SPARCDashboard, please also remove the rmid_validated flag on the record.
2). The front UI should be consistent (no green "verified" labels showing).