Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KG - SSR Resubmission Review Modal #2269

Merged
merged 2 commits into from Apr 2, 2020
Merged

Conversation

kayla-glick
Copy link
Contributor

@kayla-glick kayla-glick commented Mar 25, 2020

https://www.pivotaltracker.com/story/show/169156333

Background

When overlord users are working on a protocol using "Modify Request" button and re-submit, it is currently re-submitting all sub-service-requests that are not finished (complete, invoiced, withdrawn), locked (defined by the organizational\ status lock) or under an admin status (submitted and beyond), which causes issue in certain scenarios. Especially when this overlord is not intended to change the status of "Awaiting Requester Response" and "Draft" status to be submitted, since those are still waiting for response from study team members.

Acceptance Criteria

1). When "Modify Request" button is used on a protocol, and users are re-submitting a protocol on SPARCRequest Step 4 page, please trigger a multiple selection modal (or additional section on the page, whichever layout is more user-friendly) asking users to select/confirm which sub-service-requests they desire to re-submit;
2). This modal should only list the sub-service-requests (SSRs) that are in "Draft" and "Awaiting Requester Response" statuses, with the split/notify organization and the current statuses displayed;
3). This modal should default selection of all the sub-service-requests that meets the category (to save time), and users could un-select the ones they don't want to resubmit.
4). The SSRs that are un-selected to the resubmission should hold current status afterwards, with no emails triggered. Only the effective re-submitted SSRs should trigger status change and emails.

Screenshots

image

Additional Comments

The modal appears when clicking the Submit Request button and the request has been previously submitted. If the system satisfaction survey is turned on, the modal appears after the user 1. declines the survey, 2. completes the survey, or 3. closes the survey modal. The user can check which SSRs to submit (by default all are checked) and the NotifierLogic mailers will now use those IDs when determining where to send emails.

@Stuart-Johnson Stuart-Johnson merged commit 0e56a71 into v3.7.0 Apr 2, 2020
@Stuart-Johnson Stuart-Johnson deleted the kg-ssr_resubmission branch April 2, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants