KG - Improved Epic Interface Push Error Handling #2273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/164840135
Background:
With the Protocol Update functionality of our SPARC/Epic interface, for protocols that have already been pushed to Epic before, when there's an user change/update in SPARC, the protocol (and protocol information only piece) is being queued and batch updated to Epic daily. However, we found out that if one of the protocol is missing a validation (such as missing study type answers), the rest of the queue is skipped.
Acceptance Criteria:
Please look into ways to handle this type of errors more gracefully, so that if it happens again in the future, 1 failed protocol update is skipped, but the rest of the queue will still be pushed to Epic.
Notes from Kayla
Protocol#push_to_epic
raises the exception after rescuing it, we have to add another begin/rescue in thesend_to_epic
task. We have error handling like this elsewhere in the app to handle these exceptions.