Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KG - Fix Duplicate SSR / Skipped SSR ID Bugs #2291

Merged
merged 5 commits into from Apr 16, 2020
Merged

KG - Fix Duplicate SSR / Skipped SSR ID Bugs #2291

merged 5 commits into from Apr 16, 2020

Conversation

kayla-glick
Copy link
Contributor

https://www.pivotaltracker.com/story/show/171602442

A few issues:

  1. Protocols created in Dashboard were missing the next_ssr_id
  2. With a previously completed SSR, the find_or_create_ssr method would always find that SSR instead of rejecting it for being complete, causing a duplicate SSR to be created
  3. The subservicerequest model callbacks were mistakenly double-incrementing the Protocol next_ssr_id, causing IDs to be skipped

@Stuart-Johnson Stuart-Johnson merged commit 3802672 into v3.7.0 Apr 16, 2020
@Stuart-Johnson Stuart-Johnson deleted the kg-next_ssr_id_bug branch April 16, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stuart-Johnson Stuart-Johnson Stuart-Johnson approved these changes

Assignees
No one assigned
Labels
bug MUSC version 3.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kayla-glick @Stuart-Johnson