KG - Only prompt SSR resubmission if there are SSRs to be resubmitted #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/169156333
Per Wenjun:
The logic of the selectable SSR function on Step 5 submission is working correctly now, with locked statuses, admin statuses and complete status, and I really like the "Previously Submitted" visual cue you included in the modal.
The only suggestion I have, is that when there is no option at submission (i.e. when there is no eligible SSR to be submitted or re-submitted), could we not show the popup window? The blank window seems confusing, and it could save users one less click if we could make it smarter.