Upgrade to Ruby 2.1.5 #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Robert, we didn't include .ruby-version and .ruby-gemset as files in the repo so that it wasn't forced but .ruby-version.example is already at 2.1.5 and that is what we are running. I'm not opposed to including .ruby-version but it could potentially cause problems as new versions would force updates when they may not be required. |
|
Andrew, what do you mean by "it could potentially cause problems as new versions would force updates when they may not be required"? |
|
I spoke with the team and they are good with the change. I'm just used to apps saying stuff like "works with Ruby 1.9.3 or Ruby 2.1.5" and less of use "2.1.5" but I think in this case it's fine. Old habits die hard |
ying-pbrc
pushed a commit
to PBRCDev/sparc-request
that referenced
this pull request
May 15, 2017
…cap-api-part1 wth & jl - REDCAP API Token changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to sparc-fulfillment, it seems like we should configure this project such that all institutions are running the same version of Ruby, what do you think?
Within our Travis-CI build, upgrading Ruby from 1.9.3 to 2.1.5 did not change any RSpec test results but did cut the total run time in half!