Updated github references to use https instead of git #240
Conversation
|
FYI: I needed to update app/models/cover_letter_sanitizer.rb so that delayed_jobs would start on our dev server. The code looked like it was trying to allow "em" tags but the test: spec/models/cover_letter_sanitizer_spec.rb was asserting the allowance of "p" tags, so I updated the code so that the test continued to pass. |
| class CoverLetterSanitizer < HTML::WhiteListSanitizer | ||
| self.allowed_tags = HTML::WhiteListSanitizer.allowed_tags - %w(em) | ||
| class CoverLetterSanitizer < Rails::Html::WhiteListSanitizer | ||
| self.allowed_tags = %w(p) |
There was a problem hiding this comment.
Robert, this doesn't have to do with switching git to https and shouldn't be in this pull request.
|
I just noticed your comment. I thought it was removing 'em' tags from allowed_tags. |
|
Ah, I now I see, was the old version subtracting em from allowed tags? The p tag was the only one being tested so things should work fine. Do you want me to make any adjustments to this pull request? |
|
I'm wondering if we even need this anymore. I believe Cover Letters can't be accessed in the new setup. Might just remove the "self.allowed_tags" all together. |
|
Gotcha, we still need the "github references to use https instead of git" so maybe you accept the pull request and then take out the cover letter references and dependencies? Or, do you want me to do that? |
|
We'll take care of it |
Updated github references to use https instead of git
…_options_box_reconfig Jtm status options box reconfig
We needed this change to support our dev server's proxy.