GM - Prevent deletion of sub_service_requests record if already pushed to Fulfillment #2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleonardw9
suggested changes
Sep 19, 2022
|
@amcates Greg's only failing test is that survey thing again. Should I put a story in to clean that up and delete it? I don't think it's doing us any good if it passes locally and fails on Travis. |
|
@jleonardw9 Yes, let's remove that failing spec if it's causing issues |
jleonardw9
suggested changes
Sep 26, 2022
app/views/service_requests/cart/_cart_sub_service_requests.html.haml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users shouldn't be able to Delete a Request that has been pushed to SPARCFulfillment. The way users accomplish this is to use "Add Modify Request" and then on the dashboard screen delete the services from the cart. When the last service is deleted it triggers the SubServiceRequest to also be destroyed.
If this happens the VisitReport (and possibly other things) in SPARC Fulfillment will fail because the protocol row is storing the ID of a sub service request that will no longer exist.
Pivotal Ticket
[#181758085]