Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this should fix the test issues #3037

Merged
merged 3 commits into from Nov 18, 2022
Merged

Conversation

Ito-Eta
Copy link
Collaborator

@Ito-Eta Ito-Eta commented Nov 17, 2022

This should fix the noted errors in the tests that were causing problems.

@jleonardw9
Copy link
Contributor

Hey @Ito-Eta I think you need to add that controller code back in as well, right? Just copy and paste it from your old closed PR or branch you have locally.

@Ito-Eta
Copy link
Collaborator Author

Ito-Eta commented Nov 17, 2022

Done.

Copy link
Contributor

@jleonardw9 jleonardw9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@amcates amcates merged commit 453b9d1 into v3.10.0 Nov 18, 2022
@amcates amcates deleted the ie-epic_user_error_handling branch November 18, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants