Feature/cas

[loganfreeman]

add support for omniauth_cas

need to add the following setting in application.yml to enable it:

use_cas: true
use_cas_only: false 

use_cas: flag to turn on and off omniauth_cas
use_cas_only: if false will use both database and omniauth_cas

[wtholt]

We're working on better styling our Ruby code. Reference - https://github.com/bbatsov/ruby-style-guide

Here, use new Ruby syntax instead of hash rockets, e.g.

 event: :authentication

Parentheses for method arguments

 sign_in_and_redirect(@identity ...)

[loganfreeman]

Thanks

[loganfreeman]

Sorry, my fault. I will reopen it.

[loganfreeman]

I will correct the styling and yml file and resend the request

[loganfreeman]

I corrected the styling issue, removed the change to en.yml.
I added a helper to deal with the issue of sign in button text using different institution name.

Please review

[loganfreeman]

just found there is a local_override. removed the helper, and just use key from locale file.

[jwiel86]

Thank you for updating this file to follow our style guide specifications!

[amcates]

@loganfreeman I have a couple issues with this pull request. All of which I think can be easily resolved. I feel like the refactoring should be done separately from the actual logic added. It makes it much harder to determine exactly what has changed. Second, why did you extract from obis_setup? This isn't something that was required for your pull request. I would prefer that pull requests be concise and easily explainable.

With my comment about 'persisted?', the system creates new local identities once authenticated. This is both to make the system faster (returning identities verses querying external systems) and it gives us a hard record of what the identity looked like.

I think prior to future pull requests we should probably have a 10-15 conversation.

Thanks,

Andrew

[loganfreeman]

@amcates for the obis_setup, its purpose is to load some constants. But the calling of the initializers has some order, such that the obis_setup initializer is not the first one to be called and the constants are not available for those called before obis_setup.
So I move the constants loading stuff to environement.rb.

[loganfreeman]

@amcates I can make a new pull request without the obis_setup change. the devise initializer needs to know from application.yml what autheticattion provider to use. but it is called after obis_setup. So it needs read the application.yml again.