WTH - Dashboard: Study Level Activity Add Validation to 'Time' Data #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added validation for time with regular expression to only allow submissions up to 2 digits after decimal point. Also, added validation to ensure the numericality and that the number is greater than zero. Wrote corresponding specs to test for multiple scenarios.
wtholt
force-pushed
the
wth-study-level-activity-add-validation-to-time-data
branch
from
5f92c9d
to
c5cc83f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added validation for time with regular expression to only allow submissions up to 2 digits after decimal point.
Also, added validation to ensure the numericality and that the number is greater than zero.
Wrote corresponding specs to test for multiple scenarios.