SAW - refactor catalog organizations forms #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to share show view, no spec fixes yet
… update view, no specs
…lers except institutions
| respond_to :js, :html, :json | ||
|
|
||
| def create | ||
| @organization.build_subsidy_map() |
There was a problem hiding this comment.
unless is an institution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The forms for Institutions, Providers, Programs and Cores seemed similar enough to refactor into a single shared form.
Also refactored the controllers to work better with the new form and wrote specs for each controller.
No specs for the shared form yet and did not include Services in the refactor because they are not a type of Organization.