SAW - dashboard history add changed by column #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d, no specs [#125626111]
…ng past statuses in SPARC proper [#125626111]
|
Fix conflicts and re-review |
| @@ -386,6 +388,7 @@ def add_service | |||
| ssr.update_attribute :status, 'first_draft' | |||
| elsif ssr.status.nil? || (ssr.can_be_edited? && ssr_has_changed?(@service_request, ssr) && (ssr.status != 'complete')) | |||
| ssr.update_attribute :status, 'draft' | |||
| ssr.update_past_status(current_user) unless ssr.status.nil? | |||
There was a problem hiding this comment.
need to save off past status and then check against it
…com:sparc-request/sparc-request into saw-dashboard-history-add-changed-by-column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changed_by to past statuses, moved update_past_status to controllers instead of sub_service_request model because it now requires current_user, wrote specs to ensure a past_status is being created where it is called.
Need to add spec to sub_service_requests/put_update_spec once it has been merged in.
Did not get previous status changes from the audit trail - that will be extracted into a separate story.