New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jtm reconfig add visits #664
Conversation
…quest/sparc-request into jtm_reconfig_add_visits
@visit_group = VisitGroup.new(params[:visit_group]) | ||
if @visit_group.valid? | ||
if @arm.add_visit(@visit_group.position, @visit_group.day, @visit_group.window_before, @visit_group.window_after, @visit_group.name, 'true') | ||
@arm.increment!(:minimum_visit_count) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not part of your story, but since you are refactoring we can just get rid of incrementing the minimum visit and subject counts. They are an artifact of the older version of fulfillment.
@@ -20,7 +20,7 @@ | |||
|
|||
.protocol-sort { | |||
float: right; | |||
|
|||
padding: 0 5px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scope creep. This is already done in another PR
looks good! |
Looks good |
No description provided.