Jw fixing email story part 3 #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stuart-Johnson
approved these changes
Sep 26, 2016
jayhardee9
approved these changes
Sep 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wenjun and team only want emails sent out when adding/deleting a user. Originally they also wanted emails sent out when a user was updated, but they felt that this would overwhelm the user. So in this pull request, i'm getting rid of the logic that sends out emails for updated users.
In the email content, there is a user information table that displays an epic col if the protocol is selected for epic. Beside each user it says whether that user has epic access or not. The logic for the epic col was not hiding/showing appropriately. So that is now fixed and has full spec coverage.