Jl calendar day bug #686
Jl calendar day bug #686
Conversation
| @@ -216,7 +216,7 @@ def visits_select_options(arm, pages) | |||
| (beginning_visit..ending_visit).each do |visit_number| | |||
| visit_group = arm.visit_groups[visit_number - 1] | |||
|
|
|||
| if visit_group.day.present? | |||
| unless visit_group.day.nil? | |||
There was a problem hiding this comment.
if visit_group.day would be equivalent, and a little more understandable, in my opinion.
There was a problem hiding this comment.
I agree. I'd like to see this changed before merge.
There was a problem hiding this comment.
I'm fine either way. I think I prefer it the way it is. Both ways make sense to me.
There was a problem hiding this comment.
I accidentally changed that when I was experimenting. I'll change it back.
There was a problem hiding this comment.
Reverted back to original.
| @@ -48,6 +48,14 @@ class Arm < ActiveRecord::Base | |||
| validates :visit_count, numericality: { greater_than: 0 } | |||
| validates :subject_count, numericality: { greater_than: 0 } | |||
|
|
|||
| validate do |arm| | |||
There was a problem hiding this comment.
Is there a better way of doing this? This seems too hard-coded
There was a problem hiding this comment.
I agree, but I couldn't figure out another way to make the validations chain back down to the visit groups. Let's think on it and try to refactor down the road.
No description provided.