fixed empty shell bug and added specs

app/controllers/service_requests_controller.rb

@@ -435,10 +435,12 @@ def remove_service
     @service_request.reload
 
     @protocol = @service_request.protocol
-
-    if ssr.line_items.empty? && !ssr.submitted_at.nil?
-      send_ssr_service_provider_notifications(@service_request, ssr, true)
+
+    if ssr.line_items.empty?
       ssr.destroy
+      if !ssr.submitted_at.nil?
+        send_ssr_service_provider_notifications(@service_request, ssr, true)
+      end
     end
 
     @service_request.reload

spec/controllers/service_requests_controller/post_remove_service_spec.rb

@@ -252,6 +252,17 @@
                  :format        => :js,
                }.with_indifferent_access
         end
+
+        it 'should not delete SSR (ssr1)' do
+          post :remove_service, {
+                 :id            => service_request.id,
+                 :service_id    => service3.id,
+                 :line_item_id  => line_item1.id,
+                 :format        => :js,
+               }.with_indifferent_access
+          ssrs = [sub_service_request, ssr1, ssr2]
+          expect(service_request.sub_service_requests).to eq(ssrs)
+        end
       end
 
       context 'SSR has one service and it is removed' do
@@ -264,6 +275,17 @@
                    :format        => :js,
                  }.with_indifferent_access
         end
+
+        it 'should delete SSR (ssr2)' do
+          post :remove_service, {
+                 :id            => service_request.id,
+                 :service_id    => service3.id,
+                 :line_item_id  => line_item3.id,
+                 :format        => :js,
+               }.with_indifferent_access
+          remaining_ssrs = [sub_service_request, ssr1]
+          expect(service_request.sub_service_requests).to eq(remaining_ssrs)
+        end
       end
     end