fixing save protocol filter error #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayla-glick
suggested changes
Nov 4, 2016
| @@ -35,6 +35,7 @@ class ProtocolFilter < ActiveRecord::Base | |||
| attr_accessible :with_organization | |||
| attr_accessible :with_status | |||
| attr_accessible :with_owner | |||
| attr_accessible :sorted_by | |||
There was a problem hiding this comment.
This isn't actually an attribute on the ProtocolFilter model anymore. We changed the design to do sorting via custom Javascript that calls an AJAX request for Dashboard::ProtocolsController#index.js and it passes the "sorted_by" attribute. I think what we can do instead is in Dashboard::ProtocolFiltersController#new we should reject that attribute from params[:filterrific]
Maybe something like this:
@protocol_filter = @user.protocol_filters.new(params[:filterrific].delete(:sorted_by))
jayhardee9
approved these changes
Nov 16, 2016
jleonardw9
approved these changes
Nov 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Receiving the following errors:
ActiveModel::MassAssignmentSecurity::Error (Can't mass-assign protected attributes for ProtocolFilter: sorted_by):
app/controllers/dashboard/protocol_filters_controller.rb:25:in `new'