New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sj epic queue changes #737
Conversation
@Stuart-Johnson Can you fix the merge conflicts on this branch? |
class AddOriginToEpicQueueRecord < ActiveRecord::Migration | ||
def change | ||
add_column :epic_queue_records, :origin, :string | ||
add_column :epic_queue_records, :identity_id, :integer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a reference instead? (http://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/SchemaStatements.html#method-i-add_reference)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meh, as far as I can tell, the actual end result is identical in this instance, but I'll change it just for consistency.
@@ -0,0 +1,5 @@ | |||
class AddIdentityIdToEpicQueue < ActiveRecord::Migration | |||
def change | |||
add_column :epic_queues, :identity_id, :integer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a reference instead? (http://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/SchemaStatements.html#method-i-add_reference)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.
No description provided.