Jw epic question update #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… study type question group
…note appears when editing a study
jayhardee9
reviewed
Nov 21, 2016
| = form.object.selected_for_epic ? t(:constants)[:yes_select] : t(:constants)[:no_select] | ||
| - if form.object.selected_for_epic | ||
| = form.hidden_field :selected_for_epic, value: true | ||
| - elsif !form.object.selected_for_epic |
There was a problem hiding this comment.
Could else work just as well here?
| for k,v of answers | ||
| array_values.push(v) | ||
| nil_value = $.inArray('', array_values) > -1 | ||
| if array_values[0] == 'true' || nil_value == false |
There was a problem hiding this comment.
I'd change nil_value == false to !nil_value
wtholt
reviewed
Nov 21, 2016
| data: answers | ||
| url: "/study_type/determine_study_type_note" | ||
| success: -> | ||
| $('#study_type_note').show() |
There was a problem hiding this comment.
What happens if this errors out? Should we do some error handling here on AJAX error?
wtholt
reviewed
Nov 21, 2016
| @@ -90,6 +89,7 @@ def show | |||
| end | |||
|
|
|||
| def new | |||
| @action = params['action'] | |||
There was a problem hiding this comment.
You can access the controller action using #action_name (http://stackoverflow.com/questions/15841617/if-action-name-rails)
wtholt
reviewed
Nov 21, 2016
| .col-lg-4 | ||
| = answer_form.select :answer, options_for_select([['Yes', true], ['No', false]], answer_form.object.answer), { include_blank: 'Select One' }, { class: 'selectpicker', id: "study_type_answer_#{answer_form.object.study_type_question.friendly_id}_answer" } | ||
| - if USE_EPIC | ||
| - if action == 'new' |
wtholt
approved these changes
Nov 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information, please refer to: https://www.pivotaltracker.com/story/show/133538113