Sj service request export changes #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleonardw9
approved these changes
Dec 5, 2016
jayhardee9
reviewed
Dec 5, 2016
| @@ -136,6 +136,12 @@ def display_total_cost_per_study_otfs service_request, line_items | |||
| ############################################# | |||
| # Grand Totals | |||
| ############################################# | |||
| def display_ssr_grand_total sub_service_request | |||
| sum = 0 | |||
There was a problem hiding this comment.
Is this assignment necessary?
There was a problem hiding this comment.
I'm not 100% sure, but if you look at the file, it's written the same way all the other methods there are, I was going for consistency (and they all need revisited anyways, as another story).
| @@ -174,6 +174,9 @@ wb.add_worksheet(name: "Review") do |sheet| | |||
| line_items_visit.line_item.pricing_scheme = 'effective' if @admin_offset | |||
|
|
|||
| service_row << display_visit_based_direct_cost(line_items_visit) | |||
| puts '#' * 50 | |||
jayhardee9
approved these changes
Dec 5, 2016
wtholt
approved these changes
Dec 5, 2016
marklohr
approved these changes
Dec 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.