Jjh session #799
Merged
Jjh session #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
December 2, 2016 14:24
|
Found some bugs in the service calendar under this branch, so I'm closing this PR while I fix them. |
jwiel86
approved these changes
Dec 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes
sub_service_request_idandservice_request_idfrom the session variable.I placed a disabled hidden field named
service_request_idin the application template for JS event handlers to pull from when making AJAX requests, if needed, for convenience. The baseApplicationControllerstill sets@service_requestand@sub_service_requestas before.From now on, we need to be sure to pass along
(sub_)service_request_id, if the receiving controller needs it.If you see errors like:
ActiveRecord::RecordNotFound (Couldn't find ServiceRequest with 'id'=), then you should just tack onservice_request_id=whateverto your AJAX request, and that should do it.