Fixed parent orgs not updating children orgs [#135366883] #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayla-glick
suggested changes
Dec 8, 2016
| @@ -107,6 +107,7 @@ def process_ssrs_parent | |||
| end | |||
|
|
|||
| def update_ssr_org_name | |||
| self.org_children.each{ |org| org.update_ssr_org_name } | |||
There was a problem hiding this comment.
I think we can do this a little more efficiently. I think this would do the same thing as both lines.
SubServiceRequest.where(organization: self.all_child_organizations).each(:&update_org_tree)
There was a problem hiding this comment.
all_child_organizations will fetch every descendant of self, while org_children only returns immediate children. @BigChiefSmidgeums which should it be?
jleonardw9
approved these changes
Dec 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.