wth - step 3 additional details link bug #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayhardee9
approved these changes
Dec 28, 2016
| new_service_additional_details_submission_path(line_item.service_id, protocol_id: @protocol.id, line_item_id: line_item.id), remote: true | ||
| - service = Service.find(line_item.service_id) | ||
| - if service.questionnaires.active.present? | ||
| - unless line_item.submissions.present? |
There was a problem hiding this comment.
I think the expression in the unless should be tacked on to the if clause on line 4.
| %td | ||
| .text-center | ||
| - if service.identity_submission(current_identity).present? | ||
| = link_to "javascript:void(0);", class: 'btn btn-danger delete-submission', data: { id: "#{service.identity_submission(current_identity).first.id}", service_id: "#{service.id}", sr_id: "#{@service_request.id}", protocol_id: "#{@service_request.protocol_id}", line_item_id: "#{line_item.id}" } do |
There was a problem hiding this comment.
Also, is it necessary to string-interpolate all these data attributes? Just curious.
There was a problem hiding this comment.
Apparently, not. Thanks man. Reference - http://stackoverflow.com/questions/31061716/interpolate-variables-into-data-attributes
Reordered logic to include line_item_id param, which fixes this issue. Also, noticed logic errors in Dashboard. [#132778407]
wtholt
force-pushed
the
wth-additional-details-link-bug
branch
from
2be5424
to
8a5c3b6
Compare
jleonardw9
approved these changes
Dec 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reordered logic to include line_item_id param, which fixes this issue.
Also, noticed logic errors in Dashboard. [#132778407]