wth - Additional Detail Submissions Table Improvement #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayla-glick
suggested changes
Jan 4, 2017
| @@ -22,16 +22,18 @@ | |||
| .panel.panel-default | |||
| .panel-heading | |||
| %h4.panel-title | |||
| Additional Detail Submissions | |||
| Completed Forms | |||
There was a problem hiding this comment.
Can you YMLize the text in this table?
jayhardee9
reviewed
Jan 5, 2017
| - if submission.created_at == submission.updated_at | ||
| = submission.created_at.strftime("%m/%d/%Y") | ||
| - else | ||
| = submission.updated_at.to_date("%m/%d/%Y") |
There was a problem hiding this comment.
Aren't created_at and updated_at the same type? Just curious about why different date formatting methods are being used (strftime and to_date).
jayhardee9
approved these changes
Jan 5, 2017
wtholt
force-pushed
the
wth-additional-detail-submission-table-improvement
branch
2 times, most recently
from
c46f3c3
to
c2f7cfd
Compare
kayla-glick
approved these changes
Jan 5, 2017
Made changes to Submissions table in Dashboard. Changed name, removed ID column, added display_id for Protocol-SSR, and added date of completion/update. [#136797607]
wtholt
force-pushed
the
wth-additional-detail-submission-table-improvement
branch
from
c2f7cfd
to
9638ec7
Compare
jleonardw9
approved these changes
Jan 9, 2017
jwiel86
approved these changes
Jan 9, 2017
jleonardw9
deleted the
wth-additional-detail-submission-table-improvement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to Submissions table in Dashboard. Changed name, removed ID
column, added display_id for Protocol-SSR, and added date of
completion/update. [#136797607]