survey notifications not being sent #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please tag them with you institution as well.
Thanks!!!
On Jun 28, 2017, at 5:25 PM, Ying Wu <notifications@github.com<mailto:notifications@github.com>> wrote:
…________________________________
You can view, comment on, or merge this pull request online at:
#948
Commit Summary
* fixed survey notificaiton not being sent
File Changes
* M app/controllers/surveyor/responses_controller.rb<https://github.com/sparc-request/sparc-request/pull/948/files#diff-0> (2)
Patch Links:
* https://github.com/sparc-request/sparc-request/pull/948.patch
* https://github.com/sparc-request/sparc-request/pull/948.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#948>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AH7TzbLSadKSCu-xjcicywrhRNmC76p0ks5sIsS8gaJpZM4OIjf5>.
-------------------------------------------------------------------------
This message was secured via TLS by MUSC.
|
|
I cannot create a new label in the OS repo, i don't think i have sufficient rights to do so. Didn't see the New Label button. Would you please create one for 'LA CaTS', i will tag my PR with it after it is created. Thanks! |
|
Done!
…On Thu, Jun 29, 2017 at 10:39 AM, Ying Wu ***@***.***> wrote:
I cannot create a new label in the OS repo, i don't think i have
sufficient rights to do so. Didn't see the New Label button. Would you
please create one for 'LA CaTS', i will tag my PR with it after it is
created.
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#948 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEuH3Qp3NPssp42dHyDiP8-p91U67zVjks5sI7cygaJpZM4OIjf5>
.
|
|
Sorry, I forgot to add you as a collaborator. Please visit https://github.com/sparc-request/sparc-request/invitations to approve your invitation. In the future you will have full rights to the repo.
Andrew
From: <owner-sparc_request@musc.edu> on behalf of jwiel86 <notifications@github.com>
Reply-To: sparc-request/sparc-request <reply@reply.github.com>
Date: Thursday, June 29, 2017 at 10:41 AM
To: sparc-request/sparc-request <sparc-request@noreply.github.com>
Cc: sparc-request <sparc_request@musc.edu>, Comment <comment@noreply.github.com>
Subject: Re: [sparc-request/sparc-request] survey notifications not being sent (#948)
Done!
On Thu, Jun 29, 2017 at 10:39 AM, Ying Wu ***@***.***> wrote:
I cannot create a new label in the OS repo, i don't think i have
sufficient rights to do so. Didn't see the New Label button. Would you
please create one for 'LA CaTS', i will tag my PR with it after it is
created.
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#948 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEuH3Qp3NPssp42dHyDiP8-p91U67zVjks5sI7cygaJpZM4OIjf5>
.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#948 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AH7Tze62tmS3F9El19MsBHfWHhtNZ6HSks5sI7engaJpZM4OIjf5>.
…-------------------------------------------------------------------------
This message was secured via TLS by MUSC.
|
wtholt
approved these changes
Jun 30, 2017
jwiel86
approved these changes
Jun 30, 2017
kayla-glick
suggested changes
Jul 13, 2017
| @@ -976,7 +976,7 @@ def strip_xml_whitespace!(root) | |||
| 'rpe' => 'urn:ihe:qrph:rpe:2009', | |||
| 'hl7' => 'urn:hl7-org:v3') | |||
|
|
|||
| expect(node[1]).to be_equivalent_to(expected.root) | |||
There was a problem hiding this comment.
This was also part of the 2.1.0 Study Type Question changes. Merging v3.0.0 should remove this
| @@ -31,16 +31,20 @@ | |||
| %label.radio-inline.btn.btn-default#study_selected_for_epic_true_button{ class: protocol.selected_for_epic? ? 'active' : ''} | |||
| = form.radio_button :selected_for_epic, 'true', id: "study_selected_for_epic_true", class: 'hidden' | |||
| = t(:constants)[:yes_select] | |||
| %label.radio-inline.btn.btn-default#study_selected_for_epic_false_button{ class: protocol.selected_for_epic == false || !USE_EPIC ? 'active': ''} | |||
There was a problem hiding this comment.
This change reverts fixes for the Study Type Questions as part of 2.1.0. I think this branch just needs to be updated with the current v3.0.0.
Stuart-Johnson
approved these changes
Jul 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.