Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KG - Step 2B: Calendar Query and Rendering Need Improvement Part 4 - Subject Count #966

Merged
merged 7 commits into from Jul 13, 2017

Conversation

kayla-glick
Copy link
Contributor

@kayla-glick kayla-glick commented Jul 6, 2017

Pivotal:
https://www.pivotaltracker.com/story/show/148344231

Changes:

  1. Instead of rerendering the entire arm, rerender only the totals for the line items visit, and the arm totals. Because we have to use JSON for xeditable's error handling, we can render the necessary partials as strings and replace them with a success call in the AJAX request
  2. Move authorization methods for calendar controllers to ApplicationController to avoid duplication
  3. Move LineItemsVisitsController out of the Dashboard scope for consistency with other calendar controllers. It's not Dashboard-specific.
  4. Globalize Javascript getSRId() and getSSRId() methods. I was unable to access the getSSRId() within the context of the subject count handler which is where I realized the duplication.


private

def in_dashboard?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You already have these methods in ApplicationController. They should be available since you are inheriting from that controller.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wtholt Good catch. I meant to remove these.

@kayla-glick kayla-glick changed the base branch from master to v3.0.0 July 6, 2017 18:51
@Stuart-Johnson Stuart-Johnson merged commit cdaa8c0 into v3.0.0 Jul 13, 2017
@Stuart-Johnson Stuart-Johnson deleted the kg-calendar_optimization_pt_4 branch July 13, 2017 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants