wth - Model Specs instantiated incorrectly #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many of our model specs begin with something like this: RSpec.describe 'Protocol' do When they should be something like this: Rspec describe Protocol, type: :model do Both work, but I found that the easy way to test model validations using shoulda-matchers doesn't work using the string syntax. [#147443143] Story - https://www.pivotaltracker.com/story/show/147443143
wtholt
force-pushed
the
wth-modify-model-specs
branch
from
439e845
to
28e37bb
Compare
Stuart-Johnson
approved these changes
Jul 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of our model specs begin with something like this:
RSpec.describe 'Protocol' do
When they should be something like this:
Rspec describe Protocol, type: :model do
Both work, but I found that the easy way to test model validations using
shoulda-matchers doesn't work using the string syntax.
[#147443143]
Story - https://www.pivotaltracker.com/story/show/147443143