Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the name of the _map_to_function data member of the FunctionMatcherMixin #45

Closed
AmroAlJundi opened this issue Jan 14, 2022 · 0 comments · Fixed by #119
Closed

Fix the name of the _map_to_function data member of the FunctionMatcherMixin #45

AmroAlJundi opened this issue Jan 14, 2022 · 0 comments · Fixed by #119
Labels
good first issue Good for newcomers type: fix Iterations on existing features or infrastructure. Optimizations, refactoring, etc.

Comments

@AmroAlJundi
Copy link
Contributor

This project uses the google naming standard, and according to that standard, data members in classes should be named in small letters and separated with '_' with a trailing '_'. So the name of the data member should become 'map_to_function_'.
@AmroAlJundi AmroAlJundi added good first issue Good for newcomers type: fix Iterations on existing features or infrastructure. Optimizations, refactoring, etc. labels Jan 14, 2022
@AmroAlJundi AmroAlJundi changed the title Fix the name of the _map_to_function data member of the MapToFunctionMixin Fix the name of the _map_to_function data member of the FunctionMatcherMixin Feb 4, 2022
@AmroAlJundi AmroAlJundi linked a pull request Jun 3, 2022 that will close this issue
Fixed name of map_to_function_ #119
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers type: fix Iterations on existing features or infrastructure. Optimizations, refactoring, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed name of map_to_function_ sparcityeu/SparseBase
1 participant
@AmroAlJundi