Feature/grayreordering #124
Conversation
|
Awesome stuff. I moved the implementations to the .cc files and added explicit instantiations to the python script. It runs with the different |
| void Register(); | ||
| }; | ||
|
|
||
| enum BitMapSize{ |
There was a problem hiding this comment.
I was thinking maybe this enum should be moved to the util namespace? Because right now it's reachable like this:
sparsebase::preprocess:BitMapSize
And if we're going to be using "bitmaps" often, it might be better to place it in a more general namespace. Thoughts?
There was a problem hiding this comment.
Sounds good, the way it is reachable at the moment is non-ideal.
There was a problem hiding this comment.
We actually don't have a file for such enums yet ... I think we should keep it as it is and think of a way to organize enums like this one.
AmroAlJundi
added
state: approved
# Conflicts: # src/generate_explicit_instantiations.py # src/sparsebase/preprocess/preprocess.cc # src/sparsebase/preprocess/preprocess.h # tests/suites/sparsebase/preprocess/preprocess_tests.cc
Adding the Gray Reordering algorithm that can be applied to CSR structures.