Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easy Convert function and Format seperation #134

Merged
merged 9 commits into from
Sep 16, 2022
Merged

Easy Convert function and Format seperation #134

merged 9 commits into from
Sep 16, 2022

Conversation

AmroAlJundi
Copy link
Contributor

Applied the changes described in #133 which includes:

  1. The format type classes FormatOrderOne and FormatOrderTwo.
  2. The Convert functions inside these classes.
  3. Tests for the Convert function.
  4. Changed the documentation's Getting Started page to use this function instead of the Converter object.

@AmroAlJundi AmroAlJundi linked an issue Sep 9, 2022 that may be closed by this pull request
Add a Convert function as a member of Format classes #133
Closed
@AmroAlJundi AmroAlJundi self-assigned this Sep 9, 2022
@AmroAlJundi AmroAlJundi added state: review needed type: feature Brand new functionality, features, workflows, endpoints, etc state: pending Taking action and removed state: review needed labels Sep 9, 2022
@AmroAlJundi AmroAlJundi merged commit 3511cc5 into develop Sep 16, 2022
@AmroAlJundi AmroAlJundi deleted the feature/convert_function branch September 29, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardasener ardasener Awaiting requested review from ardasener

Assignees

@AmroAlJundi AmroAlJundi

Labels
state: pending Taking action type: feature Brand new functionality, features, workflows, endpoints, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a Convert function as a member of Format classes
1 participant
@AmroAlJundi