Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed square brackets from uniq_ptr to introduce void as ValueType again #191

Merged
merged 4 commits into from
Oct 6, 2022

Conversation

AmroAlJundi
Copy link
Contributor

As mention in #123, unique_ptrs inside formats had the Type[] notation. We removed this to be able to use void as a value type. With this came a bunch of other changes, mostly in the form of static checks of is_same<Type, void> around code that will fail if Type is void. Also, we added the ability to have type exceptions in the explicit instantiation generation script.

Changes:

  • Removed [] from Format unique_ptr members.
  • Fixed code in format constructors, readers, writers, and converters that will adjust for void value types.
  • Added void as the default value of VALUE_TYPES in CMake.
  • Added static asserts to make sure FormatOrderOne classes don't get instantiated with void as their value types.
  • Added parameter to get_inst function in the explicit generation script that allows exceptions in type templates.
  • Made void an exception of all FormatOrderOne classes.

@AmroAlJundi AmroAlJundi added state: review needed type: fix Iterations on existing features or infrastructure. Optimizations, refactoring, etc. labels Oct 2, 2022
@AmroAlJundi AmroAlJundi added this to the Milestone 3 milestone Oct 2, 2022
@AmroAlJundi AmroAlJundi self-assigned this Oct 2, 2022
@AmroAlJundi AmroAlJundi linked an issue Oct 2, 2022 that may be closed by this pull request
@AmroAlJundi AmroAlJundi merged commit e9c8bfa into develop Oct 6, 2022
@AmroAlJundi AmroAlJundi deleted the feature/remove_sqr_brck_from_arrays branch October 6, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: review needed type: fix Iterations on existing features or infrastructure. Optimizations, refactoring, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change life cycle of arrays inside formats
2 participants