Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Action for optional dependencies #223

Merged
merged 5 commits into from
Nov 1, 2022
Merged

GitHub Action for optional dependencies #223

merged 5 commits into from
Nov 1, 2022

Conversation

ardasener
Copy link
Contributor

Various changes have been made to the testing workflow:

  • Dependencies that are installed on all systems have been reduced to the essentials
  • A flag that causes the Windows MSYS2 system to be updated is turned off
  • Header-only tests are split into their own job
  • A new job for compiling and testing with some optional dependencies (currently metis and rabbit order) has been introduced.

@ardasener
Copy link
Contributor Author

While I didn't anticipate it, this PR now also includes some fixes for MetisReorder and its tests.

@ardasener ardasener added priority: now Critical priority state: review needed type: fix Iterations on existing features or infrastructure. Optimizations, refactoring, etc. type: testing Related to testing labels Nov 1, 2022
@ardasener ardasener added this to the Milestone 3 milestone Nov 1, 2022
@ardasener ardasener self-assigned this Nov 1, 2022
@ardasener ardasener linked an issue Nov 1, 2022 that may be closed by this pull request
Add Github Actions Setup for Optional Dependencies #215
Open
@ardasener ardasener merged commit 3cee4ac into develop Nov 1, 2022
@ardasener ardasener deleted the github/opt_dep_action branch November 1, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmroAlJundi AmroAlJundi AmroAlJundi approved these changes

Assignees

@ardasener ardasener

Labels
priority: now Critical priority state: review needed type: fix Iterations on existing features or infrastructure. Optimizations, refactoring, etc. type: testing Related to testing
Projects
None yet
Milestone
Milestone 3
Development

Successfully merging this pull request may close these issues.

Add Github Actions Setup for Optional Dependencies
2 participants
@ardasener @AmroAlJundi