Pulp & Patoh Integration #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration # Conflicts: # src/generate_explicit_instantiations.py # tests/suites/sparsebase/preprocess/preprocess_tests.cc
ardasener
added
the
type: feature
Atahanak
reviewed
Nov 3, 2022
| graph.m = m; | ||
| graph.out_array = csr->get_col(); | ||
| graph.out_degree_list = csr->get_row_ptr(); | ||
| graph.vertex_weights = nullptr; |
There was a problem hiding this comment.
maybe we should consider supporting weights in formats
There was a problem hiding this comment.
It is not trivial, they all support different types which is why I avoided doing so for now.
Atahanak
reviewed
Nov 3, 2022
| IDType *PatohPartition<IDType, NNZType, ValueType>::PartitionCSR( | ||
| std::vector<format::Format *> formats, PreprocessParams *params){ | ||
|
|
||
| if(typeid(IDType) != typeid(int) || typeid(NNZType) != typeid(int)){ |
There was a problem hiding this comment.
same here converter can be used.
Atahanak
approved these changes
Nov 3, 2022
Atahanak
reviewed
Nov 3, 2022
| int np = pparams->num_partitions; | ||
| IDType* partition = new IDType[n]; | ||
|
|
||
| if constexpr (std::is_signed_v<IDType> && std::is_signed_v<NNZType> && |
There was a problem hiding this comment.
try converting first and if that fails raise an exception could be better.
|
Btw, don't forget to add the |
Atahanak
previously approved these changes
Nov 6, 2022
…ration # Conflicts: # .github/workflows/testing.yml # CMakeLists.txt # src/sparsebase/config.h.in # src/sparsebase/preprocess/preprocess.cc
Atahanak
approved these changes
Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following contributions:
PulpPartitionclass wrapping the partitioner available here: https://github.com/HPCGraphAnalysis/PuLPPatohPartitionclass wrapping the partitioner available here: https://faculty.cc.gatech.edu/~umit/software.htmlMetisPartition.@paramstyle doc commentsAs of now, the following work is still needed for the partitioning side of this library to be complete:
PartitionBaseclass similar toReorderBase.XXXGraphPartitioner. And assertions can be added as well.