Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMD reordering and reorder heatmaps #231

Merged
merged 5 commits into from
Nov 4, 2022
Merged

AMD reordering and reorder heatmaps #231

merged 5 commits into from
Nov 4, 2022

Conversation

AmroAlJundi
Copy link
Contributor

@AmroAlJundi AmroAlJundi commented Nov 3, 2022 •
edited
Loading

Added AMD reorder:

  • The reorder class.
  • Modifications to the "Available" page.
  • Added AMD to the optional dependencies github action.
  • Added tests.

Added reorder heatmaps:

  • Added the preprocess.
  • Modification to the "Available" page.
  • Added tests.

Additional changes:

  • Changed std::unique_ptr constructors from default constructors to make_unique in preprocessor constructors.
  • Removed adding converters to reordering in how-to guide.

@AmroAlJundi AmroAlJundi force-pushed the feature/reorder_heatmap_amd_reorder branch 3 times, most recently from 8e912cf to 21979d2 Compare November 3, 2022 15:31
@AmroAlJundi AmroAlJundi self-assigned this Nov 3, 2022
@AmroAlJundi AmroAlJundi added state: review needed type: feature Brand new functionality, features, workflows, endpoints, etc labels Nov 3, 2022
@AmroAlJundi AmroAlJundi changed the title Feature/reorder heatmap amd reorder AMD reordering and reorder heatmaps Nov 3, 2022
Atahanak
Atahanak requested changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@Atahanak Atahanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so minor changes are required.

@AmroAlJundi AmroAlJundi added this to the Milestone 3 milestone Nov 4, 2022
@AmroAlJundi AmroAlJundi merged commit 40f198a into develop Nov 4, 2022
@AmroAlJundi AmroAlJundi deleted the feature/reorder_heatmap_amd_reorder branch November 4, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atahanak Atahanak Atahanak approved these changes

Assignees

@AmroAlJundi AmroAlJundi

Labels
type: feature Brand new functionality, features, workflows, endpoints, etc
Projects
None yet
Milestone
Milestone 3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AmroAlJundi @Atahanak