Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/file restructure 0.3 #239

Merged
merged 30 commits into from
Nov 28, 2022
Merged

Feature/file restructure 0.3 #239

merged 30 commits into from
Nov 28, 2022

Conversation

AmroAlJundi
Copy link
Contributor

@AmroAlJundi AmroAlJundi commented Nov 24, 2022 •
edited
Loading

Changed the file structure of the library:

  • Each class gets a .h and .cc file with the exception of structs, which are located with the classes that use them (e.g. RCMParams is in the RCMReorder header).
  • flattened namespaces so there isn't a namespace hierarchy. It goes sparsebase::<namespace> only, without a third level.
  • Applied the same file structure to tests.
  • Moved bases into a separate folder.
  • Fixed documentation to match the new structure.

Bug fixes:

  • In ReorderHeatmap, fixed a bug with counting edges.
  • In experiment_helper.h, replaced emplace calls with [].
  • Changed CUDACSR and CUDAArray parameterized constructor to be not owned by default.
  • Changed CUDA format converters to own the data by default.

To do:

  • Fixing tutorial_003 to match the new namespace.
  • Fixing how_to_feature to match the new file structure.

@AmroAlJundi
Refactored sparsebase/utils without removing io and converter
4a9e28d
@AmroAlJundi
Refactored sparsebase/io
86865e1
@AmroAlJundi
Moved converter out of utils
1e39d1d
@AmroAlJundi
Refactored experiment and context
9a233d3
@AmroAlJundi
Refactored converter and split format files to o1 and o2
0004608
@AmroAlJundi
Finished refactoring the format namespace
fd930e3
@AmroAlJundi
Refactored reordering
d5f40b6
@AmroAlJundi
Refactored permutation
0352faa
@AmroAlJundi
Refactored partition
b091c61
@AmroAlJundi
Refactored feature
065e6bd
@AmroAlJundi
Merge branch 'develop' into feature/file_restructure_0.3
a6a00fb 
# Conflicts:
#	src/CMakeLists.txt
#	src/generate_explicit_instantiations.py
@AmroAlJundi
Moved feature_preprocess_type to feature namespace
51761ce 
# Conflicts:
#	src/CMakeLists.txt
#	src/generate_explicit_instantiations.py
@AmroAlJundi
Refactored graph features
01cbee5
@AmroAlJundi
Refactored jaccard and removed preprocess namespace
ba2167a
@AmroAlJundi
Removed stray preprocess includes
56e56a6
@AmroAlJundi
Simplified CMake (from feature/cmake_simplification)
86347fd
@AmroAlJundi
Fixed an include
bfbfc76
@AmroAlJundi
Fixed tutorial 1, 3 and 4
633ea50
@AmroAlJundi
Fixed how_add_reordering
0cb33a2
@AmroAlJundi
Fixed getting started and explanation
ce895d0
@AmroAlJundi
CMake fix for Apple + file formatting
7f7f6be
@AmroAlJundi
Fixed warnings and bugs
2ce3753
@AmroAlJundi
Removed faulty CMake command
dcd6d68
@AmroAlJundi
Fix to CMake fix
5988b57
@AmroAlJundi AmroAlJundi self-assigned this Nov 25, 2022
@AmroAlJundi AmroAlJundi added type: bug Something isn't working priority: now Critical priority state: pending Taking action type: chore Converting measurements, reorganizing folder structure, and other necessary (less impactful) tasks labels Nov 25, 2022
@AmroAlJundi AmroAlJundi linked an issue Nov 25, 2022 that may be closed by this pull request
Refactor namespaces of the library #157
Closed
@AmroAlJundi AmroAlJundi linked an issue Nov 25, 2022 that may be closed by this pull request
Simplify CMake #188
Closed
@AmroAlJundi
Took IOBase from io to bases namespace
1489fd6
@AmroAlJundi
Merge branch 'develop' into feature/file_restructure_0.3
3ab5c38 
# Conflicts:
#	docs/pages/how_to_guides/how_add_feature.md
#	docs/pages/tutorials/002_feature_extraction.md
#	tutorials/002_feature_extraction/solved/solved.cc
@AmroAlJundi
Fixed tutorial 2
7223a72
@AmroAlJundi
Fixed how add feature
bc68aae
@AmroAlJundi
Added some incldues to feature how-to
41c9210
@AmroAlJundi AmroAlJundi merged commit 2dc0f31 into develop Nov 28, 2022
@AmroAlJundi AmroAlJundi deleted the feature/file_restructure_0.3 branch November 28, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AmroAlJundi AmroAlJundi

Labels
priority: now Critical priority state: pending Taking action type: bug Something isn't working type: chore Converting measurements, reorganizing folder structure, and other necessary (less impactful) tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify CMake Refactor namespaces of the library
1 participant
@AmroAlJundi