Feature/edge list writer #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardasener
reviewed
Dec 20, 2022
| } | ||
| edges.push_back(std::tuple<IDType, IDType>(u, v)); | ||
| } | ||
| sort(edges.begin(), edges.end(), |
There was a problem hiding this comment.
On the reader, this code ensures that there are no duplicates in the COO. For the writer, we can probably assume, there won't be any duplicates and the COO is sorted as that is the default behavior of the library. So the sort, the unique operator, and the erase could possibly be removed. A better approach is adding a parameter that can toggle them, like remove_duplicates.
There was a problem hiding this comment.
Same for all the other sort, unique, erase codes
ardasener
suggested changes
Dec 20, 2022
ardasener
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EdgeListWriter class is added.
Added doxygen style documentation.
Tests for EdgeListWriter are added.