Cleaned memory leak from FunctionMatcherMixin + Cached Execute output #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Execute that caches transformed formats
AmroAlJundi
added
type: bug
ardasener
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Executefunction inFunctionMatcherMixinwas suffering from a memory leak in the cases where it was carrying out conversions. Fixed it and added a version ofExecutein which the conversion results are cached for users to use.Changes:
CachedExecutewhich will convert formats, execute preprocessing, and keep the results of conversion.Executeto delete the conversion results to avoid memory leaks.