Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr will add a test suite and documentation comments for the members of
sparsebase::format
namespace. The test suites includes 3 different types of tests for each concrete class derived fromsparsebase::format::Format
:owned
. Then attempts to delete both instances. In a successful run, only theowned
instance will deallocate the memory hence no runtime errors will be encountered. Note that I found no way to verify if the memory is actually deallocated properly, as a result I suggest adding a "memory leak check" step to our Github Actions configuration (which can use an external program like valgrind).owned
. Then releases the data using therelease_xxx()
member functions. Then both the data and the format instance is deleted. Since the data is released from the instance a double delete should not occur in a successful run.