Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix the static file serving #347

Merged
merged 3 commits into from Jan 6, 2023
Merged

fix: fix the static file serving #347

merged 3 commits into from Jan 6, 2023

Conversation

sansyrox
Copy link
Member

@sansyrox sansyrox commented Jan 3, 2023 •
edited

This fixes the issues with static file serving of html files and also allows you to serve downloadable static files

BREAKING CHANGE:

Description

This PR fixes #343 #344

@netlify
Copy link

netlify bot commented Jan 3, 2023 •
edited

✅ Deploy Preview for robyn canceled.

Name Link
🔨 Latest commit df124cc
🔍 Latest deploy log https://app.netlify.com/sites/robyn/deploys/63b75b9b0b983c00089e37eb

@sansyrox sansyrox force-pushed the fix/html-file-serving branch 4 times, most recently from 79e461c to b5cb3a7 Compare January 4, 2023 21:40
@sansyrox sansyrox marked this pull request as ready for review January 4, 2023 21:41
@sansyrox sansyrox force-pushed the fix/html-file-serving branch 2 times, most recently from 0ef912e to 22fd203 Compare January 4, 2023 23:06
@AntoineRR
Copy link
Collaborator

@sansyrox I forgot to mention it but my last PR introduced a change: if a file_path is specified for the response, the static_file type will be added to the Response object by the set_file_path method. So there is no need to specify both type=static_file and file_path to serve a static file, but only file_path. This may be useful for this PR :)

@sansyrox
fix: fix the static file serving
2c05218 
this fixes the issues with static file serving of html files and also allows you to server downloadable static files

BREAKING CHANGE:
@sansyrox
Copy link
Member Author

sansyrox commented Jan 5, 2023

Thanks @AntoineRR :D

I have made the changes. 😄

@sansyrox sansyrox merged commit 7400776 into main Jan 6, 2023
@sansyrox sansyrox deleted the fix/html-file-serving branch January 6, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support for image file type
2 participants
@sansyrox @AntoineRR