Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update features.md - change query param syntax #520

Merged
merged 1 commit into from May 28, 2023
Merged

Update features.md - change query param syntax #520

merged 1 commit into from May 28, 2023

Conversation

urjitbhatia
Copy link
Contributor

Query params are accessed on the request object via a property, not as a subscript

Description

This PR fixes #

@urjitbhatia
Update features.md - change query param syntax
025e118 
Query params are accessed on the request object via a property, not as a subscript
@codspeed-hq
Copy link

codspeed-hq bot commented May 27, 2023

CodSpeed Performance Report

Merging #520 urjitbhatia:patch-1 (025e118) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 82 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

sansyrox
sansyrox approved these changes May 28, 2023
View reviewed changes
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Great work! 😄 🔥

@sansyrox sansyrox merged commit 2ebf875 into sparckles:main May 28, 2023
32 checks passed
@urjitbhatia urjitbhatia deleted the patch-1 branch May 30, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sansyrox sansyrox sansyrox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urjitbhatia @sansyrox