feat: Add custom exceptions #847
Open
+77
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mr-Sunglasses is attempting to deploy a commit to the sparckles Team on Vercel. A member of the Team first needs to authorize it. |
for more information, see https://pre-commit.ci
CodSpeed Performance ReportMerging #847 will not alter performanceComparing Summary
|
sansyrox
reviewed
Jun 10, 2024
sansyrox
reviewed
Jun 10, 2024
sansyrox
reviewed
Jun 10, 2024
sansyrox
reviewed
Jun 10, 2024
sansyrox
reviewed
Jun 10, 2024
sansyrox
reviewed
Jun 10, 2024
There was a problem hiding this comment.
Hey @Mr-Sunglasses ,
Thanks for the PR. I have some suggestions :D
for more information, see https://pre-commit.ci
Thanks, @sansyrox 🙏🏻, for the suggestions, I've fixed then 😄 |
|
Hey @Mr-Sunglasses 👋 Could you please add some integration tests? And the CI is also failing for some reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #550