Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in the get_crimes route #852

Merged
merged 11 commits into from
Jun 15, 2024
Merged

Conversation

Amaljyothi44
Copy link
Contributor

Description

This PR fixes #835

Ensure query parameter is treated as a string to fix default value handling issue

Copy link

vercel bot commented Jun 13, 2024

@Amaljyothi44 is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codspeed-hq bot commented Jun 14, 2024

CodSpeed Performance Report

Merging #852 will not alter performance

Comparing Amaljyothi44:main (7ab8eea) with main (d2d435c)

Summary

✅ 109 untouched benchmarks

@sansyrox
Copy link
Member

Hey @Amaljyothi44 👋

Thanks for the PR . Could you please change the title to follow conventional commits syntax ? https://www.conventionalcommits.org/en/v1.0.0/

@Amaljyothi44 Amaljyothi44 changed the title Fix issue where query parameter must be treated as a string fix: issue where query parameter must be treated as a string Jun 14, 2024
@Amaljyothi44
Copy link
Contributor Author

@sansyrox title changed

@sansyrox sansyrox changed the title fix: issue where query parameter must be treated as a string docs: fix typo in the get_crimes route Jun 15, 2024
@sansyrox
Copy link
Member

Hey @Amaljyothi44 👋

Fixed it :D

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

Copy link

vercel bot commented Jun 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2024 0:22am

@sansyrox sansyrox merged commit 466248d into sparckles:main Jun 15, 2024
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in Crime Data Endpoints Documentation Code
2 participants