feat: implement set_cookie function
#870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VishnuSanal is attempting to deploy a commit to the sparckles Team on Vercel. A member of the Team first needs to authorize it. |
CodSpeed Performance ReportMerging #870 will not alter performanceComparing Summary
Benchmarks breakdown
|
|
@VishnuSanal , could you add some integration tests? |
sansyrox
reviewed
Jun 24, 2024
sansyrox
requested changes
Jun 24, 2024
sansyrox
reviewed
Jun 25, 2024
sansyrox
reviewed
Jun 27, 2024
sansyrox
reviewed
Jun 27, 2024
|
@VishnuSanal , great work! Could you please update the Also, could you add relevant docs to the documentation? |
sansyrox
reviewed
Jul 1, 2024
sansyrox
reviewed
Jul 2, 2024
robyn/robyn.pyi
Outdated
| @@ -285,6 +285,8 @@ class Response: | |||
| headers (Union[Headers, dict]): The headers of the response or Headers directly. e.g. {"Content-Type": "application/json"} | |||
| description (Union[str, bytes]): The body of the response. If the response is a JSON, it will be a dict. | |||
| file_path (Optional[str]): The file path of the response. e.g. /home/user/file.txt | |||
|
|
|||
| set_cookie (Callable): The function to set a cookie (onto headers). | |||
There was a problem hiding this comment.
This is not needed. We only document the attributes
sansyrox
reviewed
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #854