Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug Binary type Reponse causes a crash#874 #882

Merged

Conversation

asamaayako
Copy link
Contributor

Description

This PR fixes #874 if not utf-8 data. just using Bytes. for respnose body

Copy link

vercel bot commented Jul 4, 2024

@asamaayako is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

@asamaayako asamaayako changed the title fix#874 fix: bug Binary type Reponse causes a crash#874 Jul 4, 2024
@asamaayako asamaayako marked this pull request as ready for review July 4, 2024 06:31
@asamaayako asamaayako requested a review from sansyrox July 8, 2024 02:08
Copy link

codspeed-hq bot commented Jul 9, 2024

CodSpeed Performance Report

Merging #882 will not alter performance

Comparing asamaayako:fix/Binary-type-Reponse-causes-a-crash (6d72410) with main (9f3f99c)

Summary

✅ 110 untouched benchmarks

@asamaayako asamaayako force-pushed the fix/Binary-type-Reponse-causes-a-crash branch from a94468d to 63dbe32 Compare July 10, 2024 10:07
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM . Great work👍

Copy link

vercel bot commented Jul 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2024 7:16pm

@sansyrox sansyrox merged commit 95f8a77 into sparckles:main Jul 13, 2024
60 checks passed
@goSeeFuture
Copy link

v0.57.1 No more crashes, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binary type Reponse causes a crash
3 participants